FE-350 update manifest.py to remove managed access project ids from final partition set #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
FE-350
This PR:
Updates the manifest.py script which is used to set up the partition sets for each of the four steps of the HCA ingest workflow.
All project ids - IE all datasets - should be validated, loaded into TDR and have a snapshot created. Only public access projects should then go through the final step of having their snapshot made public. This update removes the need for the human running these steps to manually exclude managed access project ids from that final step, and thus helps avoid accidentally making managed(controlled) access data public.
The Monster Ops Playbook has been updated. @snovod @sahakiann @John-Scira, you'll want to update your readme as well.
To Test:
Run manifest.py
cd ../../../orchestration/
python3 hca_manage/manifest.py load -e prod -c dcp<test_your_initials>_manifest.csv -r dcp<test_your_initials>
In a local terminal (not in the Docker image)
Verify that you see your release in the partition set lists and verify that the make_public partition set does not include 003d5674-9bf6-4e51-ab1b-8fed80c308b9
Checklist