feat: added AnVIL data dictionary column defs #4451 #4461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MillenniumFalconMechanic
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the AnVIL configuration to include data dictionary column definitions. The changes add a new JSON configuration for column definitions and a helper function to build column definitions from these JSON configurations.
- Import and use column definitions in the AnVIL config
- Implement a new utility function (buildColumnDefs) to construct table columns from the data dictionary configuration
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| site-config/anvil-cmg/dev/config.ts | Added new import and configuration for data dictionary column defs |
| app/config/utils.ts | Introduced buildColumnDefs to convert JSON configurations into table columns |
Files not reviewed (1)
- site-config/anvil-cmg/dev/dataDictionary/column-defs.json: Language not supported
frano-m
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #4451 .
Reviewers
@noop, @frano-m .
Changes