Add support for MacOS with ARM CPUs (CMake + GitHub Action) #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for build and test
…onflicting?)" This reverts commit 32bd02a.
|
So far I got it to compile, so I guess the depencies are fine now. But running the tests raises some HDF5 related errors. I've never worked with HDF5 in C++, so maybe @sanathkeshav could you please have a look at the errors? The tests fail with both |
IshaanDesai
reviewed
Oct 5, 2024
cmake/FANSConfig.cmake.in
Outdated
| @@ -18,7 +18,6 @@ if (NOT HDF5_C_IS_PARALLEL) | |||
| message(FATAL_ERROR "Parallel HDF5 implementation (mpi) required but not found!") | |||
| endif() | |||
| find_dependency(Eigen3) | |||
| find_dependency(OpenMP) | |||
There was a problem hiding this comment.
This change seems to be unrelated to this pull request. Please revert.
There was a problem hiding this comment.
this is part of the remove OpenMP dependency PR. I merged it into this PR to make it work temporarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21
Add support for macOS.
Changes in
CMakeLists.txt:New GitHub Actions workflow file for building and testing on macOS:
macos-14GitHub hosted runner (M1 CPU)clangC++ compiler (CMake default on macOS)