Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed HDR handling to use svtav1-params and accompanying values and syntax. #3

Merged
merged 4 commits into from
Dec 7, 2024
Merged

Changed HDR handling to use svtav1-params and accompanying values and syntax. #3

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f678d8
Changed HDR handling to use new syntax for svtav1-params as found in …
Cryator Dec 6, 2024
93827ff
Change color space mapping to use a dictionary instead of a single ha…
Cryator Dec 6, 2024
51ff752
Update scripts/ffmpeg_automator.py
Cryator Dec 6, 2024
6a381c1
Update scripts/ffmpeg_automator.py
Cryator Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions scripts/ffmpeg_automator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,14 @@ def get_hdr_setings(file_path):

hdr_settings = {}

# Set up dictionary mapping for known replacements of ffprobe values to be used by svtav1-params
color_space_mapping = {
'bt2020nc': 'bt2020-ncl',
'bt2020c': 'bt2020-cl',
}

for frame in media_info['frames']:
hdr_settings['color_space'] = frame['color_space']
hdr_settings['color_space'] = color_space_mapping.get(frame['color_space'], frame['color_space'])
hdr_settings['color_primaries'] = frame['color_primaries']
hdr_settings['color_transfer'] = frame['color_transfer']
hdr_settings['pix_fmt'] = frame['pix_fmt']
Expand Down Expand Up @@ -211,7 +217,7 @@ def run_ffmpeg(input_path, output_path):

if check_hdr(input_path):
hdr_settings = get_hdr_setings(input_path)
encode_settings['libsvtav1-params'] = 'hdr-opt=1:repeat-headers=1:colorprim={color_primaries}:transfer={color_transfer}:colormatrix={color_space}:master-display=R({red_x},{red_y})G({green_x},{green_y})B({blue_x},{blue_y})WP({white_point_x},{white_point_y})L({max_luminance},{min_luminance}):max-cll={max_content},{max_average} -pix_fmt {pix_fmt}'.format(**hdr_settings) # noqa: E501
encode_settings['svtav1-params'] = 'enable-hdr=1:color-primaries={color_primaries}:transfer-characteristics={color_transfer}:matrix-coefficients={color_space}:mastering-display=R({red_x},{red_y})G({green_x},{green_y})B({blue_x},{blue_y})WP({white_point_x},{white_point_y})L({max_luminance},{min_luminance}):content-light={max_content},{max_average} -pix_fmt {pix_fmt}'.format(**hdr_settings) # noqa: E501

ffmpeg = (
FFmpeg().input(input_path).output(
Expand Down
Loading