Reject negative autoboot timeout fix #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipleple
force-pushed
the
timeout-negative-fix
branch
28 times, most recently
from
77961cf
to
d2b4712
Compare
filipleple
force-pushed
the
timeout-negative-fix
branch
4 times, most recently
from
644179c
to
ccfd3da
Compare
miczyg1
requested changes
Oct 26, 2023
miczyg1
reviewed
Oct 26, 2023
MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.uni
Outdated
Show resolved
Hide resolved
filipleple
force-pushed
the
timeout-negative-fix
branch
from
1168fa7
to
5508c5a
Compare
miczyg1
previously requested changes
Oct 26, 2023
There was a problem hiding this comment.
@filipleple something is off with your editor or the code autoformatting does not work too well.
filipleple
force-pushed
the
timeout-negative-fix
branch
2 times, most recently
from
4d179f9
to
c1aa41e
Compare
|
@miczyg1 all fixes applied, your suggested solution is implemented |
|
Looks good, looks like all comments in review were addressed, marking them as resolved. @filipleple In general, please remember to add link to the fixing commit in response to review comments, according to our guidelines |
mkopec
approved these changes
Nov 6, 2023
Signed-off-by: Filip Lewiński <[email protected]>
mkopec
force-pushed
the
timeout-negative-fix
branch
from
c1aa41e
to
8a1561d
Compare
mkopec
dismissed
miczyg1’s stale review
Comments were addresser, but reviewer is on vacation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.