Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoboot timeout fix #94

Closed
wants to merge 3 commits into from
Closed

Autoboot timeout fix #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33c3b9f
MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c: a…
filipleple Oct 17, 2023
a1f53b7
autoboot timeout fixes WIP
filipleple Oct 17, 2023
8fac045
nosubmitif clause added
filipleple Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenance.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1084,7 +1084,8 @@ BootMaintCallback (
UINTN Index;
EFI_DEVICE_PATH_PROTOCOL * File;

if (Action != EFI_BROWSER_ACTION_CHANGING && Action != EFI_BROWSER_ACTION_CHANGED && Action != EFI_BROWSER_ACTION_FORM_OPEN) {

if (Action != EFI_BROWSER_ACTION_CHANGING && Action != EFI_BROWSER_ACTION_CHANGED && Action != EFI_BROWSER_ACTION_FORM_OPEN && Action != EFI_BROWSER_ACTION_REQUEST_RESET) {
//
// Do nothing for other UEFI Action. Only do call back when data is changed or the form is open.
//
Expand All @@ -1093,6 +1094,17 @@ BootMaintCallback (

Private = BMM_CALLBACK_DATA_FROM_THIS (This);

if (Action == EFI_BROWSER_ACTION_REQUEST_RESET) {
if (QuestionId == FORM_TIME_OUT_ID){
//Value->u16 = PcdGet16 (PcdPlatformBootTimeOut);
CurrentFakeNVMap->BootTimeOut = PcdGet16 (PcdPlatformBootTimeOut); //-- alt take
}
else {
return EFI_UNSUPPORTED;
}

}

if (Action == EFI_BROWSER_ACTION_FORM_OPEN) {
if (QuestionId == KEY_VALUE_TRIGGER_FORM_OPEN_ACTION) {
if (!mFirstEnterBMMForm) {
Expand Down
9 changes: 9 additions & 0 deletions MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManager.vfr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,4 +351,13 @@ formset

endform;

form formid = FORM_TIME_OUT_ID,
help = STRING_TOKEN(STR_HLP_AUTO_BOOT);
title = STRING_TOKEN(STR_FORM_STD_ERR_TITLE);
nosubmitif
prompt = STRING_TOKEN(AUTOBOOT_NOSUBMIT_IF_NEGATIVE),
//value < 0
endif;
endform;

endformset;
2 changes: 2 additions & 0 deletions MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerStrings.uni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
#language fr-FR "Modify boot driver options"
#string STR_FORM_BOOT_ADD_TITLE #language en-US "Add Boot Option"
#language fr-FR "Add Boot Option"
#string AUTOBOOT_NOSUBMIT_IF_NEGATIVE #language en-US "Autoboot Timeout value cannot be negative!"
#language fr-FR "Autoboot Timeout value cannot be negative!"
#string STR_FORM_BOOT_ADD_HELP #language en-US "Add EFI Application or Removable Fs as Boot Option"
#language fr-FR "Add EFI Application or Removable Fs as Boot Option"
#string STR_FORM_BOOT_DEL_TITLE #language en-US "Delete Boot Option"
Expand Down
Loading