OvmfPkg: include serial redirection opt by default

[macpijan]

No description provided.

[macpijan]

This MR depends on: #90
I wanted the CI build action to be already included here.

[macpijan]

@miczyg1 Another problem when trying to execute our tests was that the BootManagerMenuApp was not registered (the same Setup Menu was registered on both ESC and F2 keys).

This commit registers the BootManagerMenuApp, so F2 allows to enter it. But it only works when using QEMU in graphical mode. When pressing F2 over serial, it still enters Setup Menu, not Boot Manager App (one time boot).

[miczyg1]

@miczyg1 Another problem when trying to execute our tests was that the BootManagerMenuApp was not registered (the same Setup Menu was registered on both ESC and F2 keys).

F2 was EDK2 default for the setup, so BootManagerMenuApp should rather be ESC.

This commit registers the BootManagerMenuApp, so F2 allows to enter it. But it only works when using QEMU in graphical mode. When pressing F2 over serial, it still enters Setup Menu, not Boot Manager App (one time boot).

It might be a problem of terminal type and how it parses the escape codes. For UEFIPayload we also had problem with certain Fx keys. The solution was to set the gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType to 4.

[macpijan]

F2 was EDK2 default for the setup, so BootManagerMenuApp should rather be ESC.

@miczyg1 Default where? Any reference? Both upstream and mrchromebox just registers Setup Menu on both ESC and F2 AFAIK: https://github.com/MrChromebox/edk2/blob/uefipayload_202309/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c#L245

We use ESC as setup menu on platforms such as MSI, so it felt natural here as well.

It might be a problem of terminal type and how it parses the escape codes. For UEFIPayload we also had problem with certain Fx keys. The solution was to set the gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType to 4.

Changed in: 3fd08d4

Now F2 enters one time boot menu properly over serial (telnet).

[miczyg1]

F2 was EDK2 default for the setup, so BootManagerMenuApp should rather be ESC.

@miczyg1 Default where? Any reference? Both upstream and mrchromebox just registers Setup Menu on both ESC and F2 AFAIK: https://github.com/MrChromebox/edk2/blob/uefipayload_202309/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c#L245

Ahh that was very long time ago, like in the beginning of usage of EDK2 by us. It was F2 and arrow down IIRC so even more different from what is now: 9dd88d8

MrChromebox has it modified as well.

We use ESC as setup menu on platforms such as MSI, so it felt natural here as well.

All platforms that are based on AMI (Protectli, MSI) use DEL for setup and F11 for boot manager menu.

[macpijan]

@miczyg1 So what bindings shall be used here so we can proceed with this MR?

Esc- one time boot
F2 - setup

?

[miczyg1]

@miczyg1 So what bindings shall be used here so we can proceed with this MR?

Esc- one time boot F2 - setup

?

@macpijan exactly as above would be great. it will also somewhat match the Insyde/NovaCustom setup hotkey.

[macpijan]

@miczyg1 Changed keys mapping in: 5316967

And rebased on top of the recent github-actions branch, which should be merged first.