MTL graphics #132
Merged
MTL graphics #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miczyg1
reviewed
Jun 10, 2024
There is an assumption in `IsPciDeviceRejected()` (at least for I/O) that a BAR with all read-write bits set is invalid. However, this is not the case: when a resource is size-aligned down from the top, this may also be the case. This code causes the rejection of the iGPU (and therefore, display) in some cases with the UefiPayloadPkg, when the coreboot ESOURCE_ALLOCATION_TOP_DOWN config is enabled. It remains to be seen whether this code addresses some other issue. Signed-off-by: Benjamin Doron <[email protected]>
…t from BAR Signed-off-by: Michał Kopeć <[email protected]>
miczyg1
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.