SecureBootConfigDxe/SecureBootConfigImpl.c: add default for SB state #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkopec
force-pushed
the
edk2_global_defaults
branch
from
e9d432a
to
f32f651
Compare
mkopec
changed the title
|
It works, but only when F9 is pressed in Secure Boot menu - still some improvement is likely needed here |
mkopec
force-pushed
the
edk2_global_defaults
branch
4 times, most recently
from
bc617a9
to
32ddb94
Compare
Fixes an issue where the setting would not be restored to the default value on pressing F9. Signed-off-by: Michał Kopeć <[email protected]>
mkopec
force-pushed
the
edk2_global_defaults
branch
2 times, most recently
from
082e3d9
to
9fbcfc4
Compare
Signed-off-by: Michał Kopeć <[email protected]>
mkopec
force-pushed
the
edk2_global_defaults
branch
from
9fbcfc4
to
ce2549a
Compare
|
@macpijan Fixed the Secure Boot setting not being restored and settings not being saved on reset - added a reminder to save (or discard) when selecting reset. |
|
Thanks. Tested in QEMU as well. |
macpijan
approved these changes
Nov 9, 2023
|
Okay that seems to restore SB state. But what about keys? Are they restored to defaults? Also, if someone modified the keys and didn't enroll PK, setting SB state to enabled (if PcdSecureBootDefaultEnable is true/1) will fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the setting would not be restored to the default value on pressing F9.