Add support for iPXE and make Dasharo netwok boot menu work #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extedn OvmfPkgX64 DSC and FDF to support adding externally build ipxe.efi file in similar way as other Dasharo supported platforms do. This patch requires improvements in PlatformBootmanagerLib to register bootable iPXE option. Despite it does not have that yet it is first step to enable iPXE support in Dasharo EDK II for QEMU Q35. In long run it should allow enabling other Dasharo System Features like enabling/disabling network stack. Signed-off-by: Piotr Król <[email protected]>
OvmfPkg implementation of PlatformBootManagerLib was different than UefiPayloadPkg implementation, becuase of that there were problems in porting one to one code that register and unregister iPXE file as boot option. PlatformBootManagerLib PlatformRegisterFvBootOption gined BootNow parameter and PlatformUnregisterFvBootOption function. Signed-off-by: Piotr Król <[email protected]>
* Add ipxe.efi to the firmware volume. * Based on NetBootEnable UEFI variable register or unregister iPXE as boot option. Signed-off-by: Piotr Król <[email protected]>
pietrushnic
force-pushed
the
qemu_q35_v0.1.0-rc2
branch
4 times, most recently
from
6714500
to
aeb5207
Compare
Add support to build ipxe.efi and use it in Dasharo (UEFI) build for QEMU Q35. Signed-off-by: Piotr Król <[email protected]>
pietrushnic
force-pushed
the
qemu_q35_v0.1.0-rc2
branch
from
aeb5207
to
bcc97a6
Compare
Signed-off-by: Piotr Król <[email protected]>
miczyg1
requested changes
Oct 24, 2023
Provide gUefiPayloadPkgTokenSpaceGuid.PcdiPXEOptionName PCD as build time option in ./github/scripts/build-qemu.sh Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
2 tasks
macpijan
reviewed
Oct 25, 2023
There was a problem hiding this comment.
No actual code review on my side. I can just confirm that with the build I took from CI I could run these two tests using iPXE: Dasharo/open-source-firmware-validation@2b55fd5
|
@macpijan do you think we need a detailed review? Who can do that? |
|
@pietrushnic It looks to me that @miczyg1 already looked into that and when we resolve open thread I think we are good to move forward. |
Remove iPXE option name as built time paramater to keep Dasharo (UEFI) build for QEMU Q35 as close to UefiPayloadPkg as possible. Signed-off-by: Piotr Król <[email protected]>
pietrushnic
commented
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Dasharo/dasharo-issues#543