Check if dasharo can be installed #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLangowski
force-pushed
the
check-fused
branch
4 times, most recently
from
b213dfe
to
81878fd
Compare
PLangowski
changed the title
miczyg1
requested changes
Jul 8, 2024
PLangowski
force-pushed
the
check-fused
branch
2 times, most recently
from
3b6c64b
to
8bb0b85
Compare
|
@miczyg1 Could you look at the threads again and tell me if what I'm proposing is okay? And if not, can you suggest what else can be done (especially in #15 (comment))? |
PLangowski
force-pushed
the
check-fused
branch
3 times, most recently
from
985b946
to
d407c14
Compare
|
@miczyg1 The PR is ready for another review |
miczyg1
reviewed
Sep 4, 2024
miczyg1
reviewed
Sep 4, 2024
m-iwanicki
reviewed
Oct 7, 2024
PLangowski
force-pushed
the
check-fused
branch
2 times, most recently
from
4f681b5
to
a16bb12
Compare
miczyg1
requested changes
Oct 9, 2024
PLangowski
force-pushed
the
check-fused
branch
from
a16bb12
to
3bee131
Compare
miczyg1
reviewed
Oct 16, 2024
miczyg1
requested changes
Oct 16, 2024
|
@PLangowski please fix your editor settings. I'm done with checking the indentation in this PR already... |
|
@PLangowski Can you please try to add shfmt to pre-commit? |
PLangowski
force-pushed
the
check-fused
branch
2 times, most recently
from
2aa2a91
to
0548c9b
Compare
|
I installed the tool and fixed the indents. @macpijan I will add the pre-commit config in a separate PR, because it changes a lot in the scripts. |
|
Here is the PR with shmft pre-hook #36 |
miczyg1
approved these changes
Oct 17, 2024
|
@PLangowski the branch needs a rebase, can't fast-forward merge it |
Signed-off-by: Pawel Langowski <[email protected]>
PLangowski
force-pushed
the
check-fused
branch
from
0548c9b
to
098102e
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.