Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/advanced-issue-labeler.yml: Add labels for VP3200 platforms #1057

Merged
merged 1 commit into from
Oct 23, 2024
Merged

.github/advanced-issue-labeler.yml: Add labels for VP3200 platforms #1057

merged 1 commit into from
Oct 23, 2024

Conversation

SebastianCzapla
Copy link
Contributor

No description provided.

@SebastianCzapla
Copy link
Contributor Author

White space changes appear even if just one line is changed, not sure why this is happening.

@macpijan
Copy link
Contributor

White space changes appear even if just one line is changed, not sure why this is happening.

It's probably because you have correctly configured editor, that removes trailing whitespaces (which is great). It would be useful for yourself to confirm though, and understand the tools you use.

macpijan
macpijan requested changes Oct 23, 2024
View reviewed changes
.github/advanced-issue-labeler.yml Outdated Show resolved Hide resolved
@SebastianCzapla
Copy link
Contributor Author

Dropdown device list also updated

macpijan
macpijan approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@macpijan macpijan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see if it works.

@macpijan macpijan merged commit 0abca71 into master Oct 23, 2024
@macpijan macpijan deleted the new_platforms_vp3200 branch October 23, 2024 11:33
@macpijan
Copy link
Contributor

Works: #1103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanPrusinowski JanPrusinowski JanPrusinowski approved these changes

@macpijan macpijan macpijan approved these changes

@miczyg1 miczyg1 Awaiting requested review from miczyg1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastianCzapla @macpijan @JanPrusinowski