Vp32xx GPIO config #567
Vp32xx GPIO config #567
Conversation
| select BOARD_ROMSIZE_KB_16384 | ||
| select SOC_INTEL_ALDERLAKE_PCH_N | ||
| select SOC_INTEL_COMMON_BLOCK_HDA_VERB | ||
| select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES |
There was a problem hiding this comment.
THese resources are actually not needed on ADL-N as the SoC does not have USB4/Thunderbolt4
| select SUPERIO_ITE_IT8659E | ||
| select DRIVERS_UART_8250IO | ||
| select DRIVERS_I2C_GENERIC | ||
| select DRIVERS_INTEL_PMC |
There was a problem hiding this comment.
Same as above, Intel PMC driver would be needed with TB4 ports IIRC
| /* ------- GPIO Community 0 ------- */ | ||
|
|
||
| /* ------- GPIO Group GPP_B ------- */ | ||
| _PAD_CFG_STRUCT(GPP_B0, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_IOSSTATE(IGNORE)), |
There was a problem hiding this comment.
These _PAD_CFG_STRUCT coudl be converted to more readable macros if you execute intelp2m with -iiii flag
There was a problem hiding this comment.
Replaced with the -iiii format in this commit
|
|
||
| /* GPIO */ | ||
|
|
||
| /* GPIO */ |
There was a problem hiding this comment.
@miczyg1 is this standard junk that can be deleted or is this an indication something went wrong?
There was a problem hiding this comment.
looks like a mismatch in vGPIO pin names between inteltool and intelp2m
There was a problem hiding this comment.
Yeah, inteltool outputs vGPIO but intelp2m expects VGPIO 🙃 https://github.com/coreboot/coreboot/blob/main/util/intelp2m/platforms/adl/template.go#L14
There was a problem hiding this comment.
@mkopec Hmm, unfortunately neither replacing the vGPIO in inteltool log with VGPIO, nor replacing VGPIO with vGPIO in intelp2m and rebuilding seems to change anything.
What I've noticed is that inteltool output looks a bit different for e.g. NV4xMB:
0x0900: 0x0000000000000000 GPP_vGPIO_PCIE_0 GPIO
0x0910: 0x0000000000000000 GPP_vGPIO_PCIE_1 GPIO
0x0920: 0x0000000000000000 GPP_vGPIO_PCIE_2 GPIO
0x0930: 0x0000000000000000 GPP_vGPIO_PCIE_3 GPIO
vs
0x07f0: 0x0000000080000400 VGPIO_PCIE_0 VGPIO_PCIE_0
0x0800: 0x0000000080000400 VGPIO_PCIE_1 VGPIO_PCIE_1
0x0810: 0x0000000080000400 VGPIO_PCIE_2 VGPIO_PCIE_2
0x0820: 0x0000000080000400 VGPIO_PCIE_3 VGPIO_PCIE_3
So I've also tried sed -i 's/GPP_vGPIO_PCIE/VGPIO_PCIE/g' inteltool.log, which only yields a few less of the /* GPIO */ lines.
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
…eadable format Signed-off-by: Filip Lewiński <[email protected]>
…section Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
…single dimm Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
filipleple
had a problem deploying
to
Protectli
GitHub Actions
Failure
filipleple
had a problem deploying
to
Protectli
GitHub Actions
Failure
filipleple
had a problem deploying
to
Protectli
GitHub Actions
Failure
filipleple
had a problem deploying
to
Protectli
GitHub Actions
Failure
|
Superseded by #574 |
No description provided.