-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue fixes for MinnowBoard Turbot 0.9.0-rc2 #551
Commits on Jul 30, 2024
-
soc/intel/baytrail: Change NC GPIO to input pull up 20K
All Intel SOCs use input pullup 20K as not connected GPIO. Also GPIO output mode may be harmful. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0ded78c - Browse repository at this point
Copy the full SHA 0ded78cView commit details -
southbridge/intel/common/firmware: Use the ME file path directly
Fixes a problem where changing ME binary in the config would not result in the desired ME binary be included in the rebuilt coreboot binary. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 246f89a - Browse repository at this point
Copy the full SHA 246f89aView commit details -
src/soc/intel/baytrail/northcluster.c: add NOOP set_resources to avoi…
…d an error in log Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5ddb348 - Browse repository at this point
Copy the full SHA 5ddb348View commit details -
src/soc/intel/baytrail: Fix the FUNC_DIS bits description
BayTrail EDS is correct. MIPI is disabled in a different manner which does not use FUNC_DIS register. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cb41e44 - Browse repository at this point
Copy the full SHA cb41e44View commit details -
src/device/pciexp_device.c: Control ASPM with Kconfig option
Even if PCIEXP_ASPM is not selected, it doesn't mean all PCIe devices will have the correct ASPM disabled state set. Ensure the ASPM is disabled if it is not selected. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f2ff12f - Browse repository at this point
Copy the full SHA f2ff12fView commit details -
src/soc/intel/baytrail/Kconfig: Do not select PCIE_ASPM
Leave the choice to enable ASPM to the user via Kconfig. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3776ee5 - Browse repository at this point
Copy the full SHA 3776ee5View commit details -
src/soc/intel/baytrail/lpss.c: Configure INT_PIN as in FSP solution
Native code misses the interrupt configuration for LPSS devices. Replicate the FSP default interrupt configuration. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1d98679 - Browse repository at this point
Copy the full SHA 1d98679View commit details
Commits on Aug 14, 2024
-
soc/intel/baytrail/southcluster.c: Handle OTG and MIPI disabling prop…
…erly Disable OTG and MIPI as described in BayTrail BWG Vol. 2 (Document Number: 514148, Rev, 1.47). Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a7186ac - Browse repository at this point
Copy the full SHA a7186acView commit details -
soc/intel/baytrail/pcie.c: Add support for PCIe hotplug
By default FSP was configuring the ports as hotpluggable. Allow hotplug configuration based on Kconfig. Use the procedure described in Bay Trail BWG Vol.2 (Document Number: 514148, Rev, 1.47) to initialize PCIe port. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3b55548 - Browse repository at this point
Copy the full SHA 3b55548View commit details -
mainboard/intel/minnowmax/devicetree.cb: Use default FSP settings
Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3405d84 - Browse repository at this point
Copy the full SHA 3405d84View commit details -
mainboard/intel/minnowmax/devicetree.cb: Enable both SATA ports
Minnowboard has two SATA ports: one on the standard SATA connector, second on the expansion I/O header. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b3d3499 - Browse repository at this point
Copy the full SHA b3d3499View commit details -
mainboard/intel/minnowmax/devicetree.cb: Describe OTG controller
Describe OTG controller in the devicetree. Also add comment about known issue with writing to OTG IOSF port that will cause a hang if OTG is disabled runtime using PMC FUNC_DIS. When OTG is disabled by a soft strap in the flash descriptor, the issue does not occur though. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 27ce865 - Browse repository at this point
Copy the full SHA 27ce865View commit details -
src/soc/intel/baytrail/lpss.c: Add additional programming requirement…
…s per BWG Implement additional LPSS programming requirements per Bay Trail BWG Vol.2 (Document Number 514148, Rev, 1.47). These settings also reflect the the FSP behavior. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3351742 - Browse repository at this point
Copy the full SHA 3351742View commit details -
soc/intel/baytrail/southcluster.c: Enable resources on LPC bridge
LPC bridge device must call enable_resources to recursively enable resources for child devices. Otherwise child devices behind LPC bus may have misconfigured resources. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fa204e9 - Browse repository at this point
Copy the full SHA fa204e9View commit details -
device/pci_device.c: Clear bridge VGA16 decoding control bit after pr…
…obing After VGA16 bit was probed, it was never clear resulting in VGA16 bit being enabled in all ports without any VGA device behind them. Clear the VGA16 bit after probing and let coreboot set it back later for devices where it is necessary. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 96ccf5d - Browse repository at this point
Copy the full SHA 96ccf5dView commit details -
soc/intel/baytrail: Add TXE BIOS flow implementation
Implement TXE BIOS flow as per Bay Trail TXE BWG (Document Number: 514966, Revision 0.7). Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 434f451 - Browse repository at this point
Copy the full SHA 434f451View commit details -
payloads/external/SeaBIOS: Add option to override CBFS location
If the CBFS end is not at address 0xFFFFFFFF, then SeabIOS will not be able to find CBFS. This option allows to set the CBFS end in situations where COREBOOT region does not end at address 0xFFFFFFFF. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 06a7975 - Browse repository at this point
Copy the full SHA 06a7975View commit details -
soc/intel/baytrail: Put microcode and bootblock into BOOTBLOCK region
With CBFS_VERIFICATION one cannot fetch the early microcode update from CBFS, as walkcbfs_asm is unsafe to be compiled with CBFS_VERIFICATION. As a workaround, put a microcode copy in the IBB under a fixed address. Bootblock and microcode will be verified by TXE when TXE_SECURE_BOOT is enabled, so it will be safe to use. Also put the microcode and bootblock in the BOOTBLOCK region which will cover whole IBB to cleanly separate code and data to be verfied by TXE from the rest of CBFS. it will make the updates easier and keep CBFS_VERIFICATION working properly. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f2e8bc0 - Browse repository at this point
Copy the full SHA f2e8bc0View commit details -
src/device/dram/ddr3.c: Add ECC type to DDR3 parsed data
The spd_add_smbios17 function already assumes MEMORY_BUS_WIDTH_64 non-ECC only, but did not fill in the ecc_type information, which resulted in SMBIOS type 16 Memory Error Correction field to be out of specitions (0 is not defined). Fill in the ecc_type field as MEMORY_ARRAY_ECC_NONE. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a4eb26d - Browse repository at this point
Copy the full SHA a4eb26dView commit details -
mb/intel/minnowmax: Add layout with separate bootblock and manifests
Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2a9b24d - Browse repository at this point
Copy the full SHA 2a9b24dView commit details -
src/mainboard/intel/minnowmax: Use SPDX license headers
Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 53e9376 - Browse repository at this point
Copy the full SHA 53e9376View commit details -
3rdparty/dasharo-blobs: Bump For MinnowBoard blobs
Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ae9cd98 - Browse repository at this point
Copy the full SHA ae9cd98View commit details -
configs/config.intel_minnowmax: Add configs for regular and SB build
Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 64eed57 - Browse repository at this point
Copy the full SHA 64eed57View commit details -
.github/workflows/build.yml: Build MinnowBoard in CI
Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 77a4fa7 - Browse repository at this point
Copy the full SHA 77a4fa7View commit details -
arch/x86/smbios.c: Strip leading spaces from CPU brand string
Intel Bay Trail SoCs (confirmed on Atom E3845) have leading spaces in the CPU brand string returned by CPUID. Strip these spaces so that SMBIOS CPU string does not look weird in the EDK2 setup page and the dmidecode output. Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ad103be - Browse repository at this point
Copy the full SHA ad103beView commit details -
payloads/external/iPXE/Makefile: Use newer iPXE base revision
Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 14c7f85 - Browse repository at this point
Copy the full SHA 14c7f85View commit details -
build.sh: Add options to build Intel MinnowMax
Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2655e99 - Browse repository at this point
Copy the full SHA 2655e99View commit details -
configs: Bump EDK2 revision to pass CI build
Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5557b1a - Browse repository at this point
Copy the full SHA 5557b1aView commit details
Commits on Aug 19, 2024
-
src/device/pciexp_device.c: switch ASPM disabling order
Signed-off-by: Filip Lewiński <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 208723b - Browse repository at this point
Copy the full SHA 208723bView commit details -
src/soc/intel/baytrail/pcie.c: set power and slot number regardless o…
…f hotplug Signed-off-by: Filip Lewiński <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 59d0b38 - Browse repository at this point
Copy the full SHA 59d0b38View commit details -
src/soc/intel/baytrail/pcie.c: update hotplug function
Signed-off-by: Filip Lewiński <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 55ba4b3 - Browse repository at this point
Copy the full SHA 55ba4b3View commit details
Commits on Aug 29, 2024
-
src/mainboard/intel/minnowmax/w25q64.c: add
Required for proper BIOS lock functionality, implements mainboard_get_spi_config Signed-off-by: Filip Lewiński <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for da19e33 - Browse repository at this point
Copy the full SHA da19e33View commit details -
src/soc/intel/baytrail/lockdown.c: implement SMM BWP
Signed-off-by: Filip Lewiński <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dd311d8 - Browse repository at this point
Copy the full SHA dd311d8View commit details -
src/mainboard/intel/minnowmax/Kconfig: enable S3 suspend
Signed-off-by: Filip Lewiński <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 774e3c8 - Browse repository at this point
Copy the full SHA 774e3c8View commit details -
configs/config.intel_minnowmax*: bump up to rc2
Signed-off-by: Filip Lewiński <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b2e03f2 - Browse repository at this point
Copy the full SHA b2e03f2View commit details
Commits on Sep 6, 2024
-
Revert "src/soc/intel/baytrail/lockdown.c: implement SMM BWP"
This reverts commit dd311d8.
Configuration menu - View commit details
-
Copy full SHA for 56c4b20 - Browse repository at this point
Copy the full SHA 56c4b20View commit details
Commits on Sep 11, 2024
-
src/southbridge/intel/common/spi.c: add SMIWPEN for BYT platforms
WIP Signed-off-by: Filip Lewiński <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1834b47 - Browse repository at this point
Copy the full SHA 1834b47View commit details
Commits on Sep 12, 2024
-
soc/intel/baytrail: Make SPI work with SMM BWP
Signed-off-by: Michał Żygowski <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 622daa0 - Browse repository at this point
Copy the full SHA 622daa0View commit details