Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue fixes for MinnowBoard Turbot 0.9.0-rc2 #551

Closed
wants to merge 38 commits into from

Commits on Jul 30, 2024

  1. soc/intel/baytrail: Change NC GPIO to input pull up 20K

    All Intel SOCs use input pullup 20K as not connected GPIO.
    Also GPIO output mode may be harmful.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0ded78c View commit details
    Browse the repository at this point in the history
  2. southbridge/intel/common/firmware: Use the ME file path directly

    Fixes a problem where changing ME binary in the config would not result
    in the desired ME binary be included in the rebuilt coreboot binary.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    246f89a View commit details
    Browse the repository at this point in the history
  3. src/soc/intel/baytrail/northcluster.c: add NOOP set_resources to avoi…

    …d an error in log
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5ddb348 View commit details
    Browse the repository at this point in the history
  4. src/soc/intel/baytrail: Fix the FUNC_DIS bits description

    BayTrail EDS is correct. MIPI is disabled in a different manner which
    does not use FUNC_DIS register.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    cb41e44 View commit details
    Browse the repository at this point in the history
  5. src/device/pciexp_device.c: Control ASPM with Kconfig option

    Even if PCIEXP_ASPM is not selected, it doesn't mean all PCIe
    devices will have the correct ASPM disabled state set. Ensure
    the ASPM is disabled if it is not selected.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f2ff12f View commit details
    Browse the repository at this point in the history
  6. src/soc/intel/baytrail/Kconfig: Do not select PCIE_ASPM

    Leave the choice to enable ASPM to the user via Kconfig.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    3776ee5 View commit details
    Browse the repository at this point in the history
  7. src/soc/intel/baytrail/lpss.c: Configure INT_PIN as in FSP solution

    Native code misses the interrupt configuration for LPSS devices.
    Replicate the FSP default interrupt configuration.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1d98679 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. soc/intel/baytrail/southcluster.c: Handle OTG and MIPI disabling prop…

    …erly
    
    Disable OTG and MIPI as described in BayTrail BWG Vol. 2
    (Document Number: 514148, Rev, 1.47).
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a7186ac View commit details
    Browse the repository at this point in the history
  2. soc/intel/baytrail/pcie.c: Add support for PCIe hotplug

    By default FSP was configuring the ports as hotpluggable.
    Allow hotplug configuration based on Kconfig. Use the
    procedure described in Bay Trail BWG Vol.2 (Document
    Number: 514148, Rev, 1.47) to initialize PCIe port.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3b55548 View commit details
    Browse the repository at this point in the history
  3. mainboard/intel/minnowmax/devicetree.cb: Use default FSP settings

    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3405d84 View commit details
    Browse the repository at this point in the history
  4. mainboard/intel/minnowmax/devicetree.cb: Enable both SATA ports

    Minnowboard has two SATA ports: one on the standard SATA connector,
    second on the expansion I/O header.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    b3d3499 View commit details
    Browse the repository at this point in the history
  5. mainboard/intel/minnowmax/devicetree.cb: Describe OTG controller

    Describe OTG controller in the devicetree. Also add comment about
    known issue with writing to OTG IOSF port that will cause a hang
    if OTG is disabled runtime using PMC FUNC_DIS. When OTG is disabled
    by a soft strap in the flash descriptor, the issue does not occur
    though.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    27ce865 View commit details
    Browse the repository at this point in the history
  6. src/soc/intel/baytrail/lpss.c: Add additional programming requirement…

    …s per BWG
    
    Implement additional LPSS programming requirements per Bay Trail BWG
    Vol.2 (Document Number 514148, Rev, 1.47). These settings also reflect
    the the FSP behavior.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3351742 View commit details
    Browse the repository at this point in the history
  7. soc/intel/baytrail/southcluster.c: Enable resources on LPC bridge

    LPC bridge device must call enable_resources to recursively enable
    resources for child devices. Otherwise child devices behind LPC bus
    may have misconfigured resources.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    fa204e9 View commit details
    Browse the repository at this point in the history
  8. device/pci_device.c: Clear bridge VGA16 decoding control bit after pr…

    …obing
    
    After VGA16 bit was probed, it was never clear resulting in VGA16 bit
    being enabled in all ports without any VGA device behind them. Clear
    the VGA16 bit after probing and let coreboot set it back later for
    devices where it is necessary.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    96ccf5d View commit details
    Browse the repository at this point in the history
  9. soc/intel/baytrail: Add TXE BIOS flow implementation

    Implement TXE BIOS flow as per Bay Trail TXE BWG
    (Document Number: 514966, Revision 0.7).
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    434f451 View commit details
    Browse the repository at this point in the history
  10. payloads/external/SeaBIOS: Add option to override CBFS location

    If the CBFS end is not at address 0xFFFFFFFF, then SeabIOS will not
    be able to find CBFS. This option allows to set the CBFS end in
    situations where COREBOOT region does not end at address 0xFFFFFFFF.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    06a7975 View commit details
    Browse the repository at this point in the history
  11. soc/intel/baytrail: Put microcode and bootblock into BOOTBLOCK region

    With CBFS_VERIFICATION one cannot fetch the early microcode update
    from CBFS, as walkcbfs_asm is unsafe to be compiled with
    CBFS_VERIFICATION. As a workaround, put a microcode copy in the IBB
    under a fixed address. Bootblock and microcode will be verified by
    TXE when TXE_SECURE_BOOT is enabled, so it will be safe to use.
    
    Also put the microcode and bootblock in the BOOTBLOCK region which
    will cover whole IBB to cleanly separate code and data to be verfied
    by TXE from the rest of CBFS. it will make the updates easier and
    keep CBFS_VERIFICATION working properly.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f2e8bc0 View commit details
    Browse the repository at this point in the history
  12. src/device/dram/ddr3.c: Add ECC type to DDR3 parsed data

    The spd_add_smbios17 function already assumes MEMORY_BUS_WIDTH_64
    non-ECC only, but did not fill in the ecc_type information, which
    resulted in SMBIOS type 16 Memory Error Correction field to be out
    of specitions (0 is not defined). Fill in the ecc_type field
    as MEMORY_ARRAY_ECC_NONE.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a4eb26d View commit details
    Browse the repository at this point in the history
  13. mb/intel/minnowmax: Add layout with separate bootblock and manifests

    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2a9b24d View commit details
    Browse the repository at this point in the history
  14. src/mainboard/intel/minnowmax: Use SPDX license headers

    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    53e9376 View commit details
    Browse the repository at this point in the history
  15. 3rdparty/dasharo-blobs: Bump For MinnowBoard blobs

    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ae9cd98 View commit details
    Browse the repository at this point in the history
  16. configs/config.intel_minnowmax: Add configs for regular and SB build

    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    64eed57 View commit details
    Browse the repository at this point in the history
  17. .github/workflows/build.yml: Build MinnowBoard in CI

    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    77a4fa7 View commit details
    Browse the repository at this point in the history
  18. arch/x86/smbios.c: Strip leading spaces from CPU brand string

    Intel Bay Trail SoCs (confirmed on Atom E3845) have leading spaces
    in the CPU brand string returned by CPUID. Strip these spaces so
    that SMBIOS CPU string does not look weird in the EDK2 setup page
    and the dmidecode output.
    
    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ad103be View commit details
    Browse the repository at this point in the history
  19. payloads/external/iPXE/Makefile: Use newer iPXE base revision

    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    14c7f85 View commit details
    Browse the repository at this point in the history
  20. build.sh: Add options to build Intel MinnowMax

    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2655e99 View commit details
    Browse the repository at this point in the history
  21. configs: Bump EDK2 revision to pass CI build

    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5557b1a View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. src/device/pciexp_device.c: switch ASPM disabling order

    Signed-off-by: Filip Lewiński <[email protected]>
    filipleple committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    208723b View commit details
    Browse the repository at this point in the history
  2. src/soc/intel/baytrail/pcie.c: set power and slot number regardless o…

    …f hotplug
    
    Signed-off-by: Filip Lewiński <[email protected]>
    filipleple committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    59d0b38 View commit details
    Browse the repository at this point in the history
  3. src/soc/intel/baytrail/pcie.c: update hotplug function

    Signed-off-by: Filip Lewiński <[email protected]>
    filipleple committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    55ba4b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. src/mainboard/intel/minnowmax/w25q64.c: add

    Required for proper BIOS lock functionality, implements
    mainboard_get_spi_config
    
    Signed-off-by: Filip Lewiński <[email protected]>
    filipleple committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    da19e33 View commit details
    Browse the repository at this point in the history
  2. src/soc/intel/baytrail/lockdown.c: implement SMM BWP

    Signed-off-by: Filip Lewiński <[email protected]>
    filipleple committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    dd311d8 View commit details
    Browse the repository at this point in the history
  3. src/mainboard/intel/minnowmax/Kconfig: enable S3 suspend

    Signed-off-by: Filip Lewiński <[email protected]>
    filipleple committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    774e3c8 View commit details
    Browse the repository at this point in the history
  4. configs/config.intel_minnowmax*: bump up to rc2

    Signed-off-by: Filip Lewiński <[email protected]>
    filipleple committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    b2e03f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    56c4b20 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. src/southbridge/intel/common/spi.c: add SMIWPEN for BYT platforms

    WIP
    
    Signed-off-by: Filip Lewiński <[email protected]>
    filipleple committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1834b47 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. soc/intel/baytrail: Make SPI work with SMM BWP

    Signed-off-by: Michał Żygowski <[email protected]>
    miczyg1 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    622daa0 View commit details
    Browse the repository at this point in the history