configs/config.protectli_vp2420: bump for Timeout fix #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Żygowski <[email protected]>
miczyg1
force-pushed
the
protectli_vault_ehl/timeout_fix
branch
from
529f28b
to
9c29558
Compare
|
@mkopec tested and works now. Please review |
miczyg1
force-pushed
the
protectli_vault_ehl/timeout_fix
branch
from
0c77fcd
to
6aa8bd3
Compare
miczyg1
force-pushed
the
protectli_vault_ehl/timeout_fix
branch
from
6aa8bd3
to
ef92d10
Compare
miczyg1
force-pushed
the
protectli_vault_ehl/timeout_fix
branch
from
ef92d10
to
135f7dc
Compare
Ah the problem is not vboot itself but the amount of cache... This SoC have barely 4MB L3 cache, while FW_MAIN_A is nearly 3MB in size. Fetching it all and calculating a hash for vboot verifications fills up whole cache and romstage has no space for execution already... The issue was no triggered before because the payload was a bit smaller, but it doesn't;t change the fact that we were living on the edge here. I guess we will need a rebase and switch to VBOOT_CBFS_INTEGRATION to reduce the cache usage in pre-ram phase during verification. |
Signed-off-by: Michał Żygowski <[email protected]>
miczyg1
force-pushed
the
protectli_vault_ehl/timeout_fix
branch
from
135f7dc
to
8fbb7e0
Compare
|
To reduce the cache usage I have removed separate verstage (now vboot will run inside botoblock) |
When system_uuid CBFS file is present and contains the UUID in a string format, the driver will parse it and convert to binary format to populate the SMBIOS type 1 UUID field. TEST=Add UUID file and boot MSI PRO Z690-A DDR4 WIFI and check with dmidecode if the UUID is populated correctly. Signed-off-by: Michał Żygowski <[email protected]> Change-Id: I22f22f4e8742716283d2fcaba4894c06cef3a4bf Reviewed-on: https://review.coreboot.org/c/coreboot/+/64639 Reviewed-by: Krystian Hebel <[email protected]> Tested-by: build bot (Jenkins) <[email protected]>
…FS file not found Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
mkopec
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UNTESTED.
I accidentally bricked the platform when developing fix and had to move to vp4670. So there may be some changes between EDK2 revision which break the booting on this platform.