Protectli vault ehl/pop up fix #362
Conversation
Signed-off-by: Michał Żygowski <[email protected]>
coreboot offers two vboot schemes VBOOT_SLOTS_RW_A and VBOOT_SLOTS_RW_AB. When VBOOT_SLOTS_RW_AB is not selected then the resulting image is rather not expected to have RW_B flash regions. When only RW_A partition is used, vboot does additional full_reset cycles to try RW_B, even though it does not exist / the build was not configured for two RW partitions. To avoid it, a new vboot context flag has been introduced, VB2_CONTEXT_SLOT_A_ONLY, which can be set right after context initialization to inform vboot about absence of slot B. This will result in less full_reset cycles when vboot runs out of available slots and cause vboot to switch to recovery mode faster. Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
I guess whoever first (reviewer or author) does a local FF merge and pushes it in case of the code repos, as we don't use merge button here (signatures get lost, and we want to omit merge commits done by GH) |
I wonder if @mkopec knew that since he approved but did not merged for some reason. |
Doesn't really matter IMO. As long as it is approved, I am free to merge it as well. And I did it so I could finish the task, because I care. And whoever cares, should act in similar fashion. It is not only reviewer's interest to merge PRs that are approved. |
|
In cases where I see a lot of PRs to the same repo from the same person I tend to leave it up to them so that they can merge in their preferred order. In fact just an hour ago I merged Dasharo/edk2#64 and caused the rest of the PRs to need a rebase. |
|
It may make sense; I just wanted to know the reasoning. I doubt this is clearly described in our processes. It is all plain logic, but for a new beginner, it may not be that obvious. |
No description provided.