Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dell optiplex 9010/rel v0.1.0 #244

Open
wants to merge 40 commits into
base: dell_optiplex_9010/release
Choose a base branch
from

Conversation

pietrushnic
Copy link
Contributor

No description provided.

Copy link
Contributor

@miczyg1 miczyg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have dasharo-blobs submodule integrated, we can remove the BMP files from this PR

Comment on lines 15 to 20
CONFIG_PXE=y
CONFIG_PXE_ADD_SCRIPT=y
CONFIG_PXE_CUSTOM_BUILD_ID="12345678"
CONFIG_PXE_NO_PROMPT=y
CONFIG_PXE_ROM_ID="8086,1502"
CONFIG_PXE_SCRIPT="menu.ipxe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of adding iPXE to the CBFS image if we use EDK2 payload?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 25b7b3c

Comment on lines 15 to 20
CONFIG_PXE=y
CONFIG_PXE_ADD_SCRIPT=y
CONFIG_PXE_CUSTOM_BUILD_ID="12345678"
CONFIG_PXE_NO_PROMPT=y
CONFIG_PXE_ROM_ID="8086,1502"
CONFIG_PXE_SCRIPT="menu.ipxe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a.a

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 25b7b3c

CONFIG_BOARD_DELL_OPTIPLEX_9010=y
CONFIG_BOOTSPLASH_COMPRESS_LZMA=y
CONFIG_BOOTSPLASH_FILE="dasharo-black.bmp"
CONFIG_BOOTSPLASH_IMAGE=y
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miczyg1 do we need CONFIG_BOOTSPLASH_* options when we use CONFIG_EDK2_BOOTSPLASH_* ? Does it give any value?

pietrushnic and others added 26 commits October 25, 2022 12:02
Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Piotr Król <[email protected]>
pietrushnic and others added 13 commits October 25, 2022 13:04
Signed-off-by: Piotr Król <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Change-Id: I379841ae5ae8584fd0a59ba3511f347821ec6481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants