fix: Remove instances of undefined behavior #1652
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and trust the compiler to optimize it out
|
make sure to check foot races in AG show the correct times at game end 👍 |
EmosewaMC
reviewed
Nov 23, 2024
EmosewaMC
reviewed
Nov 25, 2024
EmosewaMC
reviewed
Nov 25, 2024
| @@ -146,7 +146,7 @@ void WriteSd0Magic(char* input, uint32_t chunkSize) { | |||
| input[2] = '0'; | |||
| input[3] = 0x01; | |||
| input[4] = 0xFF; | |||
| *reinterpret_cast<uint32_t*>(input + 5) = chunkSize; // Write the integer to the character array | |||
| std::memcpy(&input[5], &chunkSize, sizeof(uint32_t)); // Write the integer to the character array | |||
There was a problem hiding this comment.
this one is a bit harder to test, but ill send you a test case for it
EmosewaMC
reviewed
Nov 25, 2024
| @@ -54,6 +54,7 @@ struct AssetStream : std::istream { | |||
| } | |||
|
|
|||
| operator bool() { | |||
| // NEED TO FIX THIS | |||
There was a problem hiding this comment.
if this is changed make sure to check files existing and not existing with both packed and unpacked clients
Tested it, and it looks good. Still need to address a few other things. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooked up the sanitizer to try and track down any UB in our codebase