Typehandler support #117
Open
Typehandler support #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgravell Is there anything you need me to do with this PR - I'd love to get this feature in so I can start looking at the DateOnly/TimeOnly support next? |
mgravell
reviewed
Feb 7, 2025
| public override void PostProcess(in global::Dapper.UnifiedCommand cmd, global::Foo.CommandParameters args, int rowCount) | ||
| { | ||
| var ps = cmd.Parameters; | ||
| args.OutputValue = new global::CustomClassTypeHandler().Parse(ps[0]); |
There was a problem hiding this comment.
this new concerns me; I would prefer something more like:
private static global::CustomClassTypeHandler? __handler42; // some generated pattern/index
private static global::CustomClassTypeHandler __Handler42 => __handler42 ??= new();
// ...
args.OutputValue = __Handler42.Parse(ps[0]);
mgravell
reviewed
Feb 7, 2025
| @@ -10,7 +10,7 @@ namespace Dapper; | |||
| /// when processing values of type <typeparamref name="TValue"/> | |||
| /// </summary> | |||
| [ImmutableObject(true)] | |||
| [AttributeUsage(AttributeTargets.Assembly | AttributeTargets.Module | AttributeTargets.Class | AttributeTargets.Struct | AttributeTargets.Method, AllowMultiple = true)] | |||
| [AttributeUsage(AttributeTargets.Assembly | AttributeTargets.Module, AllowMultiple = true)] | |||
There was a problem hiding this comment.
presumably this is to keep the context simpler when emitting readers that may be shared/reused between targets?
|
I apologise for delay - 10 months! that's on me; life gets hectic; I've added some minor feedback, and given the delay is my fault, I'm happy to help deal with any fixup etc caused by delays. Overall approach looks sound. |
|
Looks like DAP048 got take4n by something else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my initial attempt at solving #115
I've added a test case and manually verified the output, which looks like it's picked up the changes without effecting any other tests.
Let me know if you need me to make any changes and I can push them up - I've tried to avoid changing as much of the existing code as possible.