Hanan Wahabi - Pet Park Assignment #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contracts/PetPark.sol
Outdated
| } | ||
| struct Borrower { | ||
| Gender gender; | ||
| uint256 age; |
There was a problem hiding this comment.
You can use a smaller uint for age here like uint8
| _; | ||
| } | ||
|
|
||
| function add(AnimalType _animalType, uint256 _animalcount) |
There was a problem hiding this comment.
This can be an external function (check other functions also)
| } | ||
|
|
||
| function giveBackAnimal() public { | ||
| require( |
There was a problem hiding this comment.
Since borrowers[msg.sender] is being used multiple times, better to store it in a variable
contracts/PetPark.sol
Outdated
| require(animalCounts[_animalType] > 0, "Selected animal not available"); | ||
|
|
||
| if (borrowers[msg.sender].age > 0) { | ||
| require(borrowers[msg.sender].age == _age, "Invalid Age"); |
There was a problem hiding this comment.
Since borrowers[msg.sender] is being repeated, you can store it in a memory variable
contracts/PetPark.sol
Outdated
| "No borrowed pets" | ||
| ); | ||
| animalCounts[borrowers[msg.sender].animalType] += 1; | ||
| emit Returned(borrowers[msg.sender].animalType); |
There was a problem hiding this comment.
Shouldn't this function also set the animal in borrower struct to NONE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.