Della - Pet Park Assignment

[blackqueentech]

No description provided.

[blackqueentech]

This is what is unclear to me. Zero value for enums is the first value, so the "default" gender is Male. I'm struggling to work that logic into the check for when a user hasn't borrowed any animals yet. This makes sense to me but it leads to the women <40 cat test failing.

[raxhvl]

Instead of thinking of a negative test case, how would you write a condition for women under the age of 40 inside the if clause? And then lets if they are requesting a cat, if so then revert.

[blackqueentech]

I'm still not able to pass the female under 40 borrowing cats because it hits this test. Here is my logic for the code:

u.gender != _gender - this is the clear incorrect case.
(u.gender == Gender.Female && _gender == Gender.Male) - this is an example of another clear case, feels redundant but it shows genders not matching
(u.gender == Gender.Male && _gender == Gender.Female) - this is the case I have an issue with. If I am understanding solidity correctly, before an address is added to the map, it will default to male since it is first in the Gender enum. Therefore, if an address calls borrow for the first time and is of Gender.Female, this will always fail because it won't match the default option on the enum. I need clarification as to how to get around this. I don't know why there isn't a need for a Gender.None enum option to avoid this, like there is for AnimalType.

[codingnirvana]

The age, gender and animal checks for the case when the pet was already borrowed, should be in a single if clause. Once you move them, all your tests will pass.

[blackqueentech]

How can you add them into one clause while keeping all the separate revert statements? ("Invalid Age", "Invalid Gender", "Already borrowed a pet?")

[codingnirvana]

My bad.I meant if block not if clause. Something like this

if (u.age != 0) { // If clause to check if the pet was already borrowed
  // All the conditions go here
}