Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix reentrancy contract code #1209

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Conversation

luna2163
Copy link
Contributor

When studying the contract security the dao case, I found that the contract code had some problems

and the README document was a bit rough, so I optimized it.

Finally, I still thank dapp-learning for its excellent case, salute 🫡

@luna2163 luna2163 changed the title feat:fix reentrancy contract code feat: fix reentrancy contract code Oct 26, 2024
Copy link
Collaborator

@0x-stan 0x-stan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来没有实质性的修改,另外README有中文和英文版,请不要将中文内容放入英文README

@luna2163
Copy link
Contributor Author

luna2163 commented Nov 2, 2024

看起来没有实质性的修改,另外README有中文和英文版,请不要将中文内容放入英文README

"Sorry for the mixed language in the README. As mentioned before, the documentation and code are a bit rough. For example, the Malicious contract was declared three times, so I've optimized it."

@luna2163 luna2163 requested a review from 0x-stan November 2, 2024 03:13
@jasonandjay jasonandjay merged commit 57ce16e into Dapp-Learning-DAO:main Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants