Add local version identifier to package metadata for pre-built wheels #856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix #730 so that we're following PEP 440
Currently the filename of pre-built wheels (published by GH Action in each release) follows the
public+local
versioning scheme as suggested in PEP 440 local version identifier section, but this is NOT reflected in the actual package metadata (PEP 459) and this causes discrepancy. For example, if these wheels are uploaded to a private python index, for instance a hosted python index within a company, people can't specify the exact version to install by simply usingpip install flash-attn===2.4.2+<local version>