Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local version identifier to package metadata for pre-built wheels #856

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yundai424
Copy link

@yundai424 yundai424 commented Feb 28, 2024

This attempts to fix #730 so that we're following PEP 440

Currently the filename of pre-built wheels (published by GH Action in each release) follows the public+local versioning scheme as suggested in PEP 440 local version identifier section, but this is NOT reflected in the actual package metadata (PEP 459) and this causes discrepancy. For example, if these wheels are uploaded to a private python index, for instance a hosted python index within a company, people can't specify the exact version to install by simply using pip install flash-attn===2.4.2+<local version>

@yundai424
Copy link
Author

@tridao wondering if you would mind helping take a look at this change and see if it can be merged. Thanks!

@yundai424
Copy link
Author

@tridao @piercefreeman @ksivaman et al. would greatly appreciate your help to take a look at this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[release] wheel should be published with local version available in wheel METADATA
1 participant