Windows actions #1036
Open
Windows actions #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kingbri <[email protected]>
Signed-off-by: kingbri <[email protected]>
We only build wheels for cuda 12 Signed-off-by: kingbri <[email protected]>
Signed-off-by: kingbri <[email protected]>
Builds fail without it. Signed-off-by: kingbri <[email protected]>
Build for 2.2.2 and 2.3.0 Signed-off-by: kingbri <[email protected]>
Signed-off-by: kingbri <[email protected]>
Adds python 3.12 support and fixes MSVC issues with the Windows-2022 image Signed-off-by: kingbri <[email protected]>
Used to use a non-existent variable. Signed-off-by: kingbri <[email protected]>
Not used anyways. Signed-off-by: kingbri <[email protected]>
|
Is this ready to merge? If so, @tridao can we get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I've been maintaining a fork with Windows wheels for the past ~9 months. Thanks to @jllllll for the initial action that I worked off of. It's been known that Windows is supported by Flash-attention 2 due to the existence of these wheels and various commits that have fixed Windows builds in the past.
As such, I'd like to get these actions working in the official repo so windows wheels can be available when installing via pip and actions will trigger per-release.
I've currently published the actions that do build wheels, but they'll need editing to support being triggered on release and publishing to pypi via twine. I'm not familiar with twine, so I'll need some help there if possible.
cc: @tridao