fix template union forward declaration, close rust-lang#1768

Danielmelody · Feb 23, 2023 · bf8a164 · bf8a164
1 parent b2a9472
commit bf8a164
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 0 deletions.
diff --git a/bindgen-tests/tests/expectations/tests/union_template_forward_decl.rs b/bindgen-tests/tests/expectations/tests/union_template_forward_decl.rs
diff --git a/bindgen-tests/tests/headers/union_template_forward_decl.hpp b/bindgen-tests/tests/headers/union_template_forward_decl.hpp
@@ -0,0 +1,17 @@
+// bindgen-flags: --with-derive-hash --with-derive-partialeq --with-derive-eq
+//
+template <typename value_t>
+union declare_union; // Primary template declared, but never defined.
+
+template <typename value_t> union declare_union<value_t *> {
+  declare_union() {}
+  declare_union(value_t *a_value) : value(a_value) {}
+  value_t *value;
+};
+
+template <typename value_t> union define_union {
+  define_union() {}
+  define_union(value_t *a_value) : value(a_value) {}
+  value_t *value;
+  int dummy;
+};
diff --git a/bindgen/ir/comp.rs b/bindgen/ir/comp.rs
@@ -1299,6 +1299,7 @@ impl CompInfo {
                 CXCursor_ParmDecl => true,
                 CXCursor_StructDecl | CXCursor_UnionDecl |
                 CXCursor_ClassDecl => !cur.is_definition(),
+                CXCursor_ClassTemplate => kind == CompKind::Union && !cur.is_definition(), 
                 _ => false,
             });