Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for reduction fixes: each supports implicit body, for* is an error #1661

Merged
merged 2 commits into from
Dec 25, 2024
Merged

for reduction fixes: each supports implicit body, for* is an error #1661

merged 2 commits into from
Dec 25, 2024

Conversation

edemaine
Copy link
Collaborator

Fixes two for reduction bugs

TODO: for* concat could make sense, but we'd need to detect whether the item is an array or isConcatSpreadable and either yield* or yield accordingly. Worth adding?

@edemaine edemaine merged commit 0ebaf19 into main Dec 25, 2024
4 checks passed
@edemaine edemaine deleted the reduction-fix branch December 25, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRd6 STRd6 STRd6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edemaine @STRd6