-
-
Notifications
You must be signed in to change notification settings - Fork 8
Add ':' and ';' to allowed punctuation #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ah shit, did I miss this in Could you add a test case like I did for the others? |
Pull Request Test Coverage Report for Build 1826043636
💛 - Coveralls |
Yeah I missed it too. I only noticed it when rebasing pylint-dev/pylint#5624 I'm going to add test after I finish the rebase. |
7f9832f
to
004aa99
Compare
"""This has peculiar line ending; | ||
|
||
but it should not matter. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be considered a minor issue, the spaces at the end were transformed to a newline instead of just removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like a Stripper
issue. We can't just strip all empty lines, but an empty line as last line should be strippable.
Can you open an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #54
This permit to stay sane for this: