Skip to content

Add ':' and ';' to allowed punctuation #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

Pierre-Sassoulas
Copy link
Collaborator

This permit to stay sane for this:

-        """Check the name of first argument, expect:
+        """Check the name of first argument, expect:.
 
         * 'self' for a regular method
         * 'cls' for a class method or a metaclass regular method (actually

@Pierre-Sassoulas Pierre-Sassoulas added the enhancement New feature or request label Feb 10, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 0.5.0 milestone Feb 10, 2022
@DanielNoord
Copy link
Owner

Ah shit, did I miss this in pylint?

Could you add a test case like I did for the others?

@coveralls
Copy link

coveralls commented Feb 10, 2022

Pull Request Test Coverage Report for Build 1826043636

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1825486340: 0.0%
Covered Lines: 349
Relevant Lines: 349

💛 - Coveralls

@Pierre-Sassoulas
Copy link
Collaborator Author

did I miss this in pylint?

Yeah I missed it too. I only noticed it when rebasing pylint-dev/pylint#5624

I'm going to add test after I finish the rebase.

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the add-some-allowed-punctuation branch from 7f9832f to 004aa99 Compare February 10, 2022 20:38
"""This has peculiar line ending;

but it should not matter.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be considered a minor issue, the spaces at the end were transformed to a newline instead of just removed.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a Stripper issue. We can't just strip all empty lines, but an empty line as last line should be strippable.

Can you open an issue?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants