Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redis-ha): match pdb selectors with sts selectors #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dadangnh
Copy link

What this PR does / why we need it:

Fixes the following message on GKE:

StatefulSet doesn't have a Pod Disruption Budget. This means that all Pods in the StatefulSet might experience simultaneous disruption during scenarios like node upgrades

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@DandyDeveloper
Copy link
Owner

@dadangnh Would it not be better here to update the PDB rather than the STS?

@dadangnh
Copy link
Author

@DandyDeveloper I'd like to update the PDB but it stated that the additional labels is required to prevent test pod counted

# The replica label is set on StatefulSet pods but not the Test pods
# We want to avoid including the Test pods in the budget
{{ template "redis-ha.fullname" . }}: replica

Can I remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chart/redis-ha>][BUG] PDB's selectors are not an exact match against StatefulSet selectors
2 participants