redis-ha: fix readiness probe for non-connected slaves #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Redis is running as a slave, don't pass readiness probes until and unless the replica is fully synchronised. This resolves the issue where, when Redis is upgraded, the replica is marked ready while still syncing from the master. This can lead to the master pod being terminated and restarted with no slaves ready to take over from it, leaving the Redis cluster failed until the original primary comes back up again. Signed-off-by: Chris Boot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When Redis is running as a slave, don't pass readiness probes until and unless the replica is fully synchronised.
This resolves the issue where, when Redis is upgraded, the replica is marked ready while still syncing from the master. This can lead to the master pod being terminated and restarted with no slaves ready to take over from it, leaving the Redis cluster failed until the original primary comes back up again.
Which issue this PR fixes
No issue created (yet).
Checklist
[stable/mychartname])