redis-ha: make readiness and liveness probes optional, add startup probe #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow disabling the readiness and liveness probes on both Redis and Sentinel. This can be useful if issues are encountered with the probes. Also add a startup probe which can better handle the sometimes lengthy process of loading a large database and subsequently refreshing the local copy from the primary / master server. Signed-off-by: Chris Boot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow disabling the readiness and liveness probes on both Redis and Sentinel. This can be useful if issues are encountered with the probes. Also add a startup probe which can better handle the sometimes lengthy process of loading a large database and subsequently refreshing the local copy from the primary / master server.
I have previously worked around this by adding a post-renderer to modify the generated manifests, but I'd like to do it better.
Which issue this PR fixes
None.
Checklist
[stable/mychartname])