[chart/redis-ha] ha-proxy: opt out of service account mounting #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hat
changed the title
a-hat
added a commit
to a-hat/dandydeveloper-charts
that referenced
this pull request
Aug 22, 2024
a-hat
added a commit
to a-hat/dandydeveloper-charts
that referenced
this pull request
Aug 22, 2024
…eveloper#291 Signed-off-by: a-hat <[email protected]>
a-hat
added a commit
to a-hat/dandydeveloper-charts
that referenced
this pull request
Aug 22, 2024
…eveloper#291 Signed-off-by: a-hat <[email protected]>
a-hat
added a commit
to a-hat/dandydeveloper-charts
that referenced
this pull request
Aug 22, 2024
…eveloper#291 Signed-off-by: a-hat <[email protected]>
a-hat
added a commit
to a-hat/dandydeveloper-charts
that referenced
this pull request
Aug 22, 2024
…eveloper#291 Signed-off-by: a-hat <[email protected]>
a-hat
added a commit
to a-hat/dandydeveloper-charts
that referenced
this pull request
Aug 22, 2024
…eveloper#291 Signed-off-by: a-hat <[email protected]>
a-hat
added a commit
to a-hat/dandydeveloper-charts
that referenced
this pull request
Aug 22, 2024
…eveloper#291 Signed-off-by: a-hat <[email protected]>
a-hat
added a commit
to a-hat/dandydeveloper-charts
that referenced
this pull request
Aug 22, 2024
…eveloper#291 Signed-off-by: a-hat <[email protected]>
a-hat
added a commit
to a-hat/dandydeveloper-charts
that referenced
this pull request
Aug 22, 2024
…eveloper#291 Signed-off-by: a-hat <[email protected]>
…eveloper#291 Signed-off-by: a-hat <[email protected]>
DandyDeveloper
previously approved these changes
Aug 26, 2024
|
@a-hat There's some linting issues found post update, can you correct and push? |
Signed-off-by: a-hat <[email protected]>
Yes, updated and pushed! |
DandyDeveloper
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Hello, for security hardening we would like to set
automountServiceAccountToken: falsealso on the haproxy (on the redis statefulset this is already implemented).Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])