Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/redis-ha]: Allow DNS requests to local network #289

Merged
merged 2 commits into from
Sep 27, 2024
Merged

[stable/redis-ha]: Allow DNS requests to local network #289

merged 2 commits into from
Sep 27, 2024

Conversation

llavaud
Copy link
Contributor

@llavaud llavaud commented Aug 7, 2024

  • In some situations (GKE cluster with Cloud DNS), the DNS server is configured on the local network IP range (169.254.0.0/16), so we should allow this CIDR in the default network policy.

@DandyDeveloper
Copy link
Owner

@llavaud For the sake of making this agnostic, can we ensure this is passed as a values via range statement?

Additionally, document that this specific CIDR is typical for GCP and comment it out on the defaults?

@llavaud
[stable/redis-ha]: Allow DNS requests to local network
a93b64c 
- In some situations (GKE cluster with [Cloud DNS](https://cloud.google.com/kubernetes-engine/docs/how-to/cloud-dns#architecture)), the DNS server is configured on the local network IP range
  (169.254.0.0/16), so we should allow this CIDR in the default network policy.

Signed-off-by: Laurent Lavaud <[email protected]>
@llavaud
Copy link
Contributor Author

llavaud commented Sep 22, 2024 •
edited
Loading

@llavaud For the sake of making this agnostic, can we ensure this is passed as a values via range statement?

Additionally, document that this specific CIDR is typical for GCP and comment it out on the defaults?

@DandyDeveloper Ok with this ?

@DandyDeveloper DandyDeveloper merged commit 2c336fa into DandyDeveloper:master Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DandyDeveloper DandyDeveloper DandyDeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llavaud @DandyDeveloper