[charts/redis-ha] Add ability to specify annotations for a ServiceAccount #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecrajeev
approved these changes
Jul 31, 2024
|
@DandyDeveloper - could you please review here? I want to use this so I can use a sidecar to upload backups to s3. |
|
@duncaan Letting the linting and such go through and I'll get it merged when they finish! (Sorry for the delay, the auto-assigning isn't working and I'm not getting notifications) |
DandyDeveloper
approved these changes
Aug 21, 2024
a-hat
pushed a commit
to a-hat/dandydeveloper-charts
that referenced
this pull request
Aug 22, 2024
…ount (DandyDeveloper#287) Signed-off-by: a-hat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Specifying an annotation on a service account is useful when restoring or backing up to S3.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])