[charts/redis-ha] Support minReadySeconds in Redis statefulset #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjamesbrown
changed the title
DandyDeveloper
previously approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Introduced in 1.22, so we should be fine merging pending CI.
FYI, you need to increment the patch version on the Chart.yaml @andrewjamesbrown
|
@DandyDeveloper any update here? thanks! |
|
@DandyDeveloper any chance we can get this shipped? Thanks! |
DandyDeveloper
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Supports minReadySeconds for redis-ha statefulsets; so we can ensure during a rolling update, the specified number of seconds elapses before moving to the next replica.
Note this parameter is only stable in k8s v1.25.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])