Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable/redis-ha: add endpointAdditionalProperties for redis-ha and haproxy serviceMonitor #260

Conversation

trawler
Copy link
Contributor

@trawler trawler commented Sep 20, 2023

What this PR does / why we need it:

This PR enables setting additional flags for the prometheus-exporter and redis-ha serviceMonitors (see: EndpointSpec).
I opted to create an open nested object called endpointAdditionalProperties so that it's not necessary to explicitly expose all available endpoint settings.

Usage Example:

exporter:
  serviceMonitor:
    enabled: true
    endpointAdditionalProperties:
      relabelings:
        - sourceLabels: [__address__]
          targetLabel: foo
          replacement: bar

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@trawler trawler force-pushed the redis-ha-serviceMonitor-relabeling branch 2 times, most recently from 59b8f6a to 3b84690 Compare September 20, 2023 15:16
@trawler trawler marked this pull request as ready for review September 20, 2023 15:17
@trawler
Copy link
Contributor Author

trawler commented Sep 21, 2023

@DandyDeveloper - can you trigger the tests?

@trawler
Copy link
Contributor Author

trawler commented Sep 22, 2023

tagging also @ssalaues: can you also help in triggering the tests for this PR? Thanks!

@DandyDeveloper
Copy link
Owner

Running the tests now :)

@trawler
Copy link
Contributor Author

trawler commented Sep 22, 2023

hmm looks like my commit was not signed. checking.

@trawler trawler force-pushed the redis-ha-serviceMonitor-relabeling branch from 3b84690 to ad1d2dd Compare September 22, 2023 10:10
@trawler
Copy link
Contributor Author

trawler commented Sep 22, 2023

@DandyDeveloper I re-pushed with a signed commit. Sorry for the hassle!

@DandyDeveloper DandyDeveloper merged commit e121986 into DandyDeveloper:master Sep 22, 2023
2 checks passed
@trawler trawler deleted the redis-ha-serviceMonitor-relabeling branch September 22, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants