#256 Add support for HAProxy service externalIPs #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix haproxy.image.serviceAccountName to haproxy.serviceAccountName in README.md - add missing haproxy.service.loadBalancerIP entry - add new haproxy.service.externalIPs Signed-off-by: Martin Fleurke <[email protected]>
amfleurke
changed the title
DandyDeveloper
previously approved these changes
Feb 5, 2024
|
@amfleurke I'm approving the checks. Sorry this has been pending for so damn long. |
DandyDeveloper
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and 2 bugfixes in README:
What this PR does / why we need it:
I need to deploy the HAProxy service as type LoadBalancer with a specified IP address using externalIPs field.
This field is not supported yet
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])