[charts/redis-ha] Add extraAnnotations value allowing to add annotations for every sing… #234
+77
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le resource generate, from a single value declaration
Signed-off-by: Imanol Valiente <[email protected]>
DandyDeveloper
previously approved these changes
Mar 2, 2023
|
LGTM, sorry for this taking so long. Merging when it passes. |
DandyDeveloper
previously approved these changes
Mar 2, 2023
|
@imvalient Looks like the CI sees some problems. Possibly indentation? Can you triple check your work here? |
…meters and added default annotation values to avoid nil exceptions
|
@DandyDeveloper thanks, it should be fixed now. |
DandyDeveloper
approved these changes
Mar 3, 2023
|
@DandyDeveloper, I think that you have to approve the needed GitHub actions, right? |
|
@imvalient I actually think GH ACtions was having problems the other day... Going to do what I can to get these running. |
DandyDeveloper
previously approved these changes
Mar 8, 2023
DandyDeveloper
approved these changes
Mar 8, 2023
@imvalient Looks like its still broken. FYI: Do some local |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le resource generate, from a single value declaration
What this PR does / why we need it:
I've been using this chart for a long time. Right now, I'm trying to add a custom annotation to all the resources generated by this chart, but currently, it's not supported. This PR enables this feature.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])