[stable/redis-ha]: Enable relabeling and metricRelabeling on resources: ServiceMonitor #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 15, 2022 15:25
…tor. Signed-off-by: lftgl <[email protected]>
Signed-off-by: lftgl <[email protected]>
|
is there anything that needs to be done to get this merged? |
cstruck
reviewed
Feb 20, 2023
| @@ -6,7 +6,7 @@ keywords: | |||
| - redis | |||
| - keyvalue | |||
| - database | |||
| version: 4.16.0 | |||
| version: 4.17.4 | |||
There was a problem hiding this comment.
Suggested change
| version: 4.17.4 | |
| version: 4.23.0 |
|
@DandyDeveloper is there anything needed here to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lftgl [email protected]
What this PR does / why we need it:
With this PR I would like to create the possibility to apply relabeling settings and the ServiceMonitor resources.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])