Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-116] Remove authorization based on Members AD group #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[DEV-116] Remove authorization based on Members AD group #180

wants to merge 1 commit into from

Conversation

mandarl
Copy link
Contributor

@mandarl mandarl commented Oct 30, 2024 •
edited
Loading

The 'Members' AD group hasn't been updated in a while and is no longer in sync with active members.
So we remove references to this group from calendar code.
Tested manually.

zphelj
zphelj reviewed Nov 8, 2024
View reviewed changes
Copy link

@zphelj zphelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense to me. One question, have you confirmed that AuthUser prevents anyone but a logged in member from creating an event in your testing?

@mandarl
Copy link
Contributor Author

mandarl commented Nov 8, 2024 •
edited
Loading

have you confirmed that AuthUser prevents anyone but a logged in member from creating an event in your testing?

Good question! Yes, non-logged-in users will be prompted to login while submitting an event. This is same as current behavior.

chrome_xTgli17KMn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zphelj zphelj zphelj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mandarl @zphelj