Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suwi] Week 03 #796

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[suwi] Week 03 #796

wants to merge 7 commits into from

Conversation

sungjinwi
Copy link
Contributor

@sungjinwi sungjinwi commented Dec 27, 2024

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@sungjinwi sungjinwi requested a review from a team as a code owner December 27, 2024 12:07
@github-actions github-actions bot added the py label Dec 27, 2024
@sungjinwi sungjinwi requested review from EcoFriendlyAppleSu and imsosleepy and removed request for EcoFriendlyAppleSu December 27, 2024 12:09
Copy link
Contributor

@EgonD3V EgonD3V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3주차도 수고 많으셨습니다 풀이를 참고해서 기존 코드를 개선하거나 여러 방법으로 풀어보시면 도움되실 것 같습니다 화이팅

Comment on lines +10 to +13
if sum(comb) > target :
return
elif sum(comb) == target :
return ans.append(comb.copy())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if sum(comb) > target :
return
elif sum(comb) == target :
return ans.append(comb.copy())
sum_comb = sum(comb)
if sum_comb > target :
return
elif sum_comb == target :
return ans.append(comb.copy())

sum의 경우, O(n)을 소요하기 때문에 2회 사용하기 보다는 변수에 저장하는 편이 좋을 것 같습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants