-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[suwi] Week 03 #796
Open
sungjinwi
wants to merge
7
commits into
DaleStudy:main
Choose a base branch
from
sungjinwi:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[suwi] Week 03 #796
+90
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungjinwi
requested review from
EcoFriendlyAppleSu and
imsosleepy
and removed request for
EcoFriendlyAppleSu
December 27, 2024 12:09
EgonD3V
approved these changes
Dec 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3주차도 수고 많으셨습니다 풀이를 참고해서 기존 코드를 개선하거나 여러 방법으로 풀어보시면 도움되실 것 같습니다 화이팅
Comment on lines
+10
to
+13
if sum(comb) > target : | ||
return | ||
elif sum(comb) == target : | ||
return ans.append(comb.copy()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if sum(comb) > target : | |
return | |
elif sum(comb) == target : | |
return ans.append(comb.copy()) | |
sum_comb = sum(comb) | |
if sum_comb > target : | |
return | |
elif sum_comb == target : | |
return ans.append(comb.copy()) |
sum의 경우, O(n)을 소요하기 때문에 2회 사용하기 보다는 변수에 저장하는 편이 좋을 것 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review
로 설정해주세요.