Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added T20 Cricket Dataset #1

Closed
wants to merge 2 commits into from
Closed

Added T20 Cricket Dataset #1

wants to merge 2 commits into from

Conversation

MihirRajeshPanchal
Copy link

@MihirRajeshPanchal MihirRajeshPanchal commented Oct 1, 2023

This pull request solves issue : #2

@dagshub
Copy link

dagshub bot commented Oct 1, 2023

@yonomitt
Copy link
Contributor

@MihirRajeshPanchal Thanks for your contribution! Before we can accept this, could you please add a README.md for the T20 Cricket Dataset under its folder?

@MihirRajeshPanchal
Copy link
Author

Sure @yonomitt

@MihirRajeshPanchal
Copy link
Author

@yonomitt I have added the readme file in the commit : 71489a1

@yonomitt
Copy link
Contributor

Hi @MihirRajeshPanchal, I just realized that you had added the data directly to your fork of the open-source-ml-datasets. What we're looking for is:

  1. Create a Dagshub repo for the dataset
  2. Have your (this) PR add a folder for the dataset with a README.md
  3. The README.md should point to the DagsHub repo with the data

As an example, checkout the repo we created for Audio datasets last year: https://dagshub.com/DagsHub/audio-datasets

So to accept this PR, please move the data to a new DagsHub repo and update the README to point to that repo.

Thanks!

@MihirRajeshPanchal MihirRajeshPanchal closed this by deleting the head repository Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants