Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user input from google colab #106

Merged
merged 19 commits into from
Nov 7, 2021
Merged

Conversation

mohithg
Copy link
Contributor

@mohithg mohithg commented Nov 6, 2021

  • Remove pyInquirer usage from our cli, to avoid conflicts with prompt_toolkit
  • Allow user input from google colab

Copy link
Member

@guysmoilov guysmoilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks nice, it's surprisingly easy to replace PyInquirer

@guysmoilov
Copy link
Member

@mohithg Did you test this on google colab?
Before merging, I'd want to confirm that it works with pip install git+https://github.com/DAGsHub/fds.git@mohithg/get-user-input-colab

@mohithg
Copy link
Contributor Author

mohithg commented Nov 7, 2021

@guysmoilov its working really good in colab with the command you mentioned
image

@guysmoilov guysmoilov merged commit cbe3769 into main Nov 7, 2021
@guysmoilov guysmoilov deleted the mohithg/get-user-input-colab branch November 7, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants