Merge pull request #10 from Daafip/dev

update docs, typo in param names
Daafip · Apr 8, 2024 · d7ec0ea · d7ec0ea
2 parents 10ca3c6 + 1049f02
commit d7ec0ea
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/docs/Forward model.ipynb b/docs/Forward model.ipynb
@@ -6,7 +6,8 @@
    "metadata": {},
    "source": [
     "# NOTEBOOK FOR REFERENCE ONLY!\n",
-    "Shows how model is implemented step by step **without** a BMI"
+    "Shows how model is implemented step by step **without** a BMI<br>\n",
+    "**And now snow models as implemented in 1.4.0.**"
    ]
   },
   {

diff --git a/src/HBV/HBV_bmi.py b/src/HBV/HBV_bmi.py
@@ -208,7 +208,7 @@ def updating_dict_var_obj(self) -> None:
     def updating_obj_from_dict_var(self) -> None:
         """Function which inverts the dictionary above & sets objects correctly"""
         param_names = ["Imax", "Ce", "Sumax", "Beta", "Pmax", "Tlag", "Kf", "Ks", "FM"]
-        stor_names = ["Si", "Su", "Sf", "Ss", "SP"]
+        stor_names = ["Si", "Su", "Sf", "Ss", "Sp"]
         self.set_pars([self.dict_var_obj[par] for par in param_names])
         self.set_storage([self.dict_var_obj[stor] for stor in stor_names])