-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#159] Header 관련 로직 추가 #160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfmoon-mind
requested review from
ChoiSangwon,
chan0310,
SujinKim1127,
JooHui-void and
jwo0o0
December 28, 2023 13:54
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SujinKim1127
reviewed
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
배포 쪽에서 오류가 나는것 같아요!
확인부탁드립니당~!
수정했어용 |
SujinKim1127
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니당!!!
SujinKim1127
added a commit
that referenced
this pull request
Jan 26, 2024
* feat: 상세정보 api 연결 * feat: 좋아요, 스크랩 api 연결 * feat: 댓글 api 연결 * style: 반응형으로 변경 * style: 배경 흰색으로 변경 * [#159] Header 관련 로직 추가 (#160) * feat: Route에 따른 header 조건 지정 * fix: 바텀네비게이션 announce -> notice로 수정 * refactor: style 코드들 정렬 * feat: 더보기 클릭 라우팅 추가 * feat: 코드 스타일 업데이트 * feat: 스크롤 코드 삭제 * feat: bottom nav bar true로 설정 * feat: 상위 3개만 출력하도록 변경 * feat: 로그인에서 utility header 추가 * refactor: 불필요한 코드 삭제 * refactor: PR시 빌드 확인 코드 삭제 * feat: main에서 api 콜 수정 * refactor: header 설정 추가 * fix: storybook 업데이트 * style: 빠진 글자 수정 * [#164] 레이아웃 관련 스타일 수정 (#165) * style: global.css body 요소에 height 설정, padding 추가(네비게이션바 100px) * style: 랜딩 페이지 배경 이미지 position:fixed로 변경 * fix: 랜딩 페이지에서 헤더 미노출 로직 추가 * feat: 상세정보 api 연결 * feat: 좋아요, 스크랩 api 연결 * feat: 댓글 api 연결 * style: 반응형으로 변경 * style: 배경 흰색으로 변경 * style: 빠진 글자 수정 * chore: console 삭제 * feat: 댓글에 닉네임 추가 * style: 댓글 디자인 반응형으로 수정 --------- Co-authored-by: Sanghyeon Sim <[email protected]> Co-authored-by: 김정우 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
얘기할 것
수정사항
/
로 이동/announce
로 되어 있던 부분 수정Check List
main
브랜치의 최신 상태를 반영하고 있는지 확인Screenshot