Skip to content

Potion unlock rework, 1.21 edition #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Robotgiggle
Copy link
Contributor

All of the changes from #671, but for the 1.21 version.

Currently a draft, since I haven't actually tested any of this apart from making sure it builds.

@DaFuqs
Copy link
Owner

DaFuqs commented May 27, 2025

Could you get it to run?

Alternatively I can have a look no problem. IIRC the potion unlock rework here is the last thing to get all 1.20.1 and 1.21 up to par.

@Robotgiggle Robotgiggle marked this pull request as ready for review May 27, 2025 22:53
@Robotgiggle
Copy link
Contributor Author

Should be good to go now.

Copy link
Owner

@DaFuqs DaFuqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very, very nice. Ty!

@DaFuqs DaFuqs merged commit 7e8db9b into DaFuqs:1.21.1-aria-for-painters May 28, 2025
2 checks passed
@Robotgiggle Robotgiggle deleted the potion-workshop-1.21 branch May 28, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants