Mod Compat PR #501
Merged
Mod Compat PR #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FORGET TO REVERT THE TEST CHANGE YOU MADE TO BRISTLE MEAD
… breaks. Also, spatial storage is explicitly designed to be able to move budding blocks. Don't remove that from AE2. Resonance exists anyways, its not like this breaks things too much...
DaFuqs
requested changes
Oct 4, 2024
| @@ -1,7 +1,6 @@ | |||
| { | |||
| "replace": false, | |||
| "values": [ | |||
| "#spectrum:budding_blocks", | |||
There was a problem hiding this comment.
This entry here mainly is:
- to give players a reason to go back to the DD from time to time
- make them not complain when they notice that moved budding blocks can not be used to generate ink, once the ink update it out (which will still take a while and will prob. be 1.21+, so eh)
There was a problem hiding this comment.
doesn't the resonance enchantment have these same issues anyways?
| "immersive_weathering:spectrum/purple_bark": "Oak Bark?", | ||
| "immersive_weathering:spectrum/blue_bark": "Oak Bark?", | ||
| "immersive_weathering:spectrum/green_bark": "Oak Bark?", | ||
| "immersive_weathering:spectrum/red_bark": "Oak Bark?" |
There was a problem hiding this comment.
The other spectrum blocks do use scrambled names instead.
Why should we handle it differently here?
There was a problem hiding this comment.
Unlike most spectrum blocks, this is something that a player is VERY likely to encounter in natural gameplay, as stripping a colored tree will yield its respective bark regardless of progression. Additionally, my planned cloak overhaul PR (that is waiting on changes to Revelationary) will be adding more instances like this.
src/main/resources/data/spectrum/recipes/mod_integration/affinity/TODO.txt
Outdated
Show resolved
Hide resolved
...ain/resources/data/spectrum/recipes/mod_integration/create/enchantment_upgrade/capacity.json
Outdated
Show resolved
Hide resolved
src/main/resources/data/spectrum/recipes/mod_integration/gofish/enchanter/book_deepfry.json
Show resolved
Hide resolved
...urces/data/spectrum/recipes/mod_integration/neepmeat/enlightening/elder_guardian_memory.json
Show resolved
Hide resolved
.../resources/data/spectrum/recipes/mod_integration/neepmeat/enlightening/endermite_memory.json
Show resolved
Hide resolved
src/main/resources/data/spectrum/recipes/spirit_instiller/head_fusion/fox_arctic.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am completely burnt out right now so there's still some TODO files for what i was going to do later, also there is no guidebook entries.
Let this go to main?
Can't be bothered to write out everything in this PR, also i changed kindling AI a bit while working on the vivisection recipe
yes there is a merge conflict but right now i don't care