Gitignore for GO lang #468
Conversation
K-Kumar-01
requested review from
adelkahomolova,
Jakub-Vacek,
prokopsimek and
ryzzaki
as code owners
Removed some unnecessary js code Added the go code for it
| }); | ||
|
|
||
| it('Does not change correct .gitignore', async () => { | ||
| const gitignore = `${basicGitignore}\npackage-lock.json\n`; |
There was a problem hiding this comment.
There is no package-lock.json in Go lang. Please, change it.
There was a problem hiding this comment.
we need to simply remove it or add any other file likt that of package-lock.json.
There was a problem hiding this comment.
You can just remove the package-lock.json
Added appropriate comment headings Changed the url
|
@K-Kumar-01 , I appreciate the time you invest in our repository. I hope you enjoyed the contributing to DX-Scanner! It's approved by me. I'll just wait for a review from my colleague as we think it's the best practice to have 2 approvals to keep the high quality of code. |
| expect(evaluated).toEqual(PracticeEvaluationResult.practicing); | ||
| }); | ||
|
|
||
| it('Returns notPracticing if there the .gitignore is NOT set correctly', async () => { |
There was a problem hiding this comment.
Returns notPracticing if the .gitignore is NOT set correctly
There was a problem hiding this comment.
Made the requested change in the latest push
|
|
I have changed the sentence regrading this test case. |
|
@K-Kumar-01 the test is not failing because there is bad text in the name of the test. You need to fix the code. The test is failing. I can't merge it since there is something bad. |
OK I will see to it and try to fix the problem. |
|
@adelkahomolova |
|
Hi, @K-Kumar-01 , I looked at it. The problem is that you check also the |
|
@adelkahomolova The comment above vendor stated dependency directories. so i thought it shouldn't be a comment. |
|
Thank you for the changes, @K-Kumar-01 , I've already merged your PR :) |
|
🎉 This PR is included in version 3.45.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Created a new practice that checks correctly set .gitignore for Go lang.
Motivation and Context
The issue related to the PR is linked here
Types of changes
Checklist: