-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diana #9
base: master
Are you sure you want to change the base?
Diana #9
Conversation
<h1>360 i</h1> | ||
<h2> | ||
<div id="box"> | ||
<div class = "box" id = "LogIn"><a href="main.html">LOG IN</a></div></h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we talked about this in class, but I would definitely eliminate the <h2>
tag, or at the very least, only wrap it around the Log In text: <div class = "box" id = "LogIn"><a href="main.html"><h2>LOG IN</h2></a></div>
|
||
<h1>360 i</h1> | ||
<h2> | ||
<div id="box"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't seem to close this <div>
- this can create a ton of problems!
quis nostrud exercitation</h3> | ||
|
||
|
||
<div class="img"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to close this <div>
!
@rabbitrg I'd look over my notes and make these changes- a lot of these are going to cause you big problems down the line |
<div class="img"> | ||
<img src="image/background.jpg" style= "widht:100%; height:100%"; position:absolute;top:0 z-index: -1;> | ||
|
||
<style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move your style to an external stylesheet-- like style.css that you then bring in via <link rel="stylesheet" type="text/css" href="style.css">
in the <head>
color: rgb(3, 196, 173); | ||
margin: auto; | ||
letter-spacing: 1px; | ||
margin-top: 20px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep your indentation specific- it will help keep you organized
@@ -0,0 +1,111 @@ | |||
<html> | |||
<head> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't be writing any of your content html in the <head>
, that's for things like <title>
or importing css or js files. This should all be inside of the <body>
tag
<body> | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the html you want to be rendered to the page should be inside of here
No description provided.