Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(impala): support impala #184

Merged
merged 27 commits into from
Nov 28, 2023
Merged

feat(impala): support impala #184

merged 27 commits into from
Nov 28, 2023

Conversation

LuckyFBB
Copy link
Collaborator

@LuckyFBB LuckyFBB commented Oct 17, 2023

  • 新增 ImpalaSQL 语法文件,参考 ImpalaSQL 官方文档
  • 关键字的词法规则名称前加上 KW_ 前缀
  • 梳理需要自动补全的语法规则,并优化对应的语法规则文件
  • 添加基础语法相关的单元测试, 所有支持的语法都要有单元测试用例
  • ImpalaSQL 支持自动补全功能
  • ImpalaSQL 支持按语句切分SQL功能
  • ImpalaSQL 自动补全功能的单元测试

@HaydenOrz
Copy link
Collaborator

#177

@HaydenOrz HaydenOrz marked this pull request as draft October 23, 2023 07:54
@HaydenOrz HaydenOrz added the enhancement Enhance existing feature label Nov 1, 2023
@HaydenOrz HaydenOrz assigned Cythia828 and LuckyFBB and unassigned Cythia828 Nov 2, 2023
@LuckyFBB LuckyFBB force-pushed the feat_impala branch 2 times, most recently from 04484a4 to 2f33b7a Compare November 19, 2023 11:27
@LuckyFBB LuckyFBB marked this pull request as ready for review November 23, 2023 08:47
@LuckyFBB LuckyFBB changed the title WIP: feat(impala): support impala feat(impala): support impala Nov 23, 2023
src/grammar/impala/ImpalaSqlLexer.g4 Outdated Show resolved Hide resolved
src/grammar/impala/ImpalaSqlParser.g4 Outdated Show resolved Hide resolved
src/grammar/impala/ImpalaSqlParser.g4 Outdated Show resolved Hide resolved
src/grammar/impala/ImpalaSqlParser.g4 Show resolved Hide resolved
src/grammar/impala/ImpalaSqlParser.g4 Outdated Show resolved Hide resolved
src/grammar/impala/ImpalaSqlParser.g4 Outdated Show resolved Hide resolved
src/grammar/impala/ImpalaSqlParser.g4 Outdated Show resolved Hide resolved
src/grammar/impala/README.md Outdated Show resolved Hide resolved
@HaydenOrz HaydenOrz added the new features New feature or request label Nov 28, 2023
@HaydenOrz
Copy link
Collaborator

LGTM

@HaydenOrz HaydenOrz merged commit e203f1a into DTStack:main Nov 28, 2023
5 checks passed
@LuckyFBB LuckyFBB deleted the feat_impala branch May 6, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing feature new features New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants