Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): normalise route path with vite in @remix-run/dev #2613

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

sebastien-comeau
Copy link
Contributor

Description

Fixes Remix config optimizeDeps.entries for Vite Dep Optimization Options on Windows. I've tested it in Windows and Linux and no issue on both platforms.

Related PR created by me on Remix remix-run/remix#10258

Related Azure Boards Work Items

Screenshots (if applicable)

Checklist

  • I have tested the changes locally
  • I have updated the documentation if necessary
  • I have added/updated tests that prove my fix is effective or that my feature works
  • I have checked that my code follows the project's coding style by running npm run format:check
  • I have checked that my code contains no linting errors by running npm run lint
  • I have checked that my code contains no type errors by running npm run typecheck
  • I have checked that all unit tests pass by running npm run test:unit -- run
  • I have checked that all e2e tests pass by running npm run test:e2e

Test Instructions

Additional Notes

@sebastien-comeau sebastien-comeau merged commit ec94281 into main Nov 22, 2024
2 checks passed
@sebastien-comeau sebastien-comeau deleted the seb/patch-remix-run-dev branch November 22, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants